Move key changes into FormulaRuntime. #333
Conversation
Laimiux
force-pushed
the
laimonas/cleanup
branch
from
fb905d4 to
0e26da1
Compare
JaCoCo Code Coverage 78.72% ✅
Generated by 🚫 Danger |
| ) : ManagerDelegate { | ||
| private val implementation = formula.implementation() | ||
| private var manager: FormulaManagerImpl<Input, *, Output>? = null | ||
| private var hasInitialFinished = false |
There was a problem hiding this comment.
This is not needed anymore - previously it was used to ensure that on formula start, we wait for all actions to start running before emitting a value. Currently, it's done within FormulaManagerImpl.
| threadChecker.check("Input arrived on a wrong thread.") | ||
| if (!runtime.isKeyValid(input)) { | ||
| runtime.terminate() | ||
| runtime = runtimeFactory() |
There was a problem hiding this comment.
It was a bit weird that we recreate the runtime if key changes. Instead, the runtime will handle state reset internally.
| performTermination() | ||
| terminateManager(manager) | ||
|
|
||
| if (localInputId != inputId && !terminated) { |
There was a problem hiding this comment.
The logic here looks fine, but it's a little confusing that we have both manager.isTerminated() and a terminated flag (and that they'll have opposite values).
There was a problem hiding this comment.
They could potentially both be true at the same time, will add documentation and maybe rename it.
Laimiux
force-pushed
the
laimonas/cleanup
branch
2 times, most recently
from
b27b7a3 to
b0b40c7
Compare
Laimiux
force-pushed
the
laimonas/cleanup
branch
from
b0b40c7 to
66a7c63
Compare
What
To remove duplication within RxJavaRuntime and FlowRuntime, I'm moving logic into shared
FormulaRuntimeclass